Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove MountReturn from scaffolded ct support file #21119

Merged
merged 2 commits into from Apr 19, 2022

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Apr 18, 2022

User facing changelog

Remove unused MountReturn import from scaffolded support file

Additional details

MountReturn isn't an exported or defined type for @cypress/vue so it was throwing an error on project setup. We never used it anyway since we were scaffolding:

declare global {
  namespace Cypress {
    interface Chainable {
      mount: typeof mount
    }
  }
}

Since we do typeof mount, the return type is derived from mount.

How has the user experience changed?

The component.ts file no longer has an invalid import.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@ZachJW34 ZachJW34 requested review from a team as code owners April 18, 2022 18:16
@ZachJW34 ZachJW34 requested review from jennifer-shehane and removed request for a team April 18, 2022 18:16
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 18, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 18, 2022



Test summary

17872 0 217 0Flakiness 0


Run details

Project cypress
Status Passed
Commit e72068e
Started Apr 18, 2022 6:17 PM
Ended Apr 18, 2022 6:31 PM
Duration 13:51 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 merged commit 17fe5d9 into 10.0-release Apr 19, 2022
@lmiller1990 lmiller1990 deleted the zachw/vue2-mount-return branch April 19, 2022 03:11
tgriesser added a commit that referenced this pull request Apr 20, 2022
…e-config

* 10.0-release:
  chore: Move component-index generation to scaffold-config package (#21090)
  fix: label text should be clickable to toggle snapshot highlight (#21122)
  feat: add next preset to webpack-dev-server-fresh (#21069)
  chore: add dev-servers as deps to server to be included in the binary (#21142)
  fix: do not highlight preExtension if selected option is renameFolder (#21121)
  fix(unify): Remove 'Reconfigure' dropdown from Testing Type chooser (#21063)
  feat(unify): launchpad header breadcrumbs and reusable tooltip component (#20648)
  test: add windows-test-kitchensink job (#20847)
  fix: aut centering and height calculation (#21019)
  chore: fix tests that fail on windows (#21055)
  fix: running a new test after already having run tests (#21087)
  fix: ct project setup framework keys for next and nuxt (#21116)
  fix: remove MountReturn from scaffolded ct support file (#21119)
  fix: do not scaffold fixtures if folder exist (#21078)
  fix: revert "fix: types for Cypress.Commands.add (#20376)" (#21104)
  chore: Update Chrome (stable) to 100.0.4896.127 and Chrome (beta) to 101.0.4951.34 (#21083)
  fix: types for Cypress.Commands.add (#20376) (#20377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants