Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dev-servers as deps to server to be included in the binary #21142

Merged
merged 9 commits into from Apr 19, 2022

Conversation

ZachJW34
Copy link
Contributor

User facing changelog

Bundle @cypress/webpack-dev-server-fresh and @cypress/vite-dev-server-fresh in the binary.

Additional details

Add @cypress/webpack-dev-server-fresh and @cypress/vite-dev-server-fresh to dependencies of packages/server/package.json. This ensures they are bundled in the binary.

Refactored how vite is imported in @cypress/vite-dev-server-fresh. Since this package is now part of the binary, we need to require.resolve from the projectRoot to emulate how the package was previously resolved.

Fixed an issue where the disted files for @cypress/webpack-dev-server-fresh weren't being copied (thanks @tgriesser)

How has the user experience changed?

New Object API now works when testing with the binary.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@ZachJW34 ZachJW34 requested a review from a team as a code owner April 19, 2022 22:07
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 19, 2022

Thanks for taking the time to open a PR!

@ZachJW34 ZachJW34 requested review from jennifer-shehane and removed request for a team April 19, 2022 22:07
@cypress
Copy link

cypress bot commented Apr 19, 2022



Test summary

17872 0 217 0Flakiness 1


Run details

Project cypress
Status Passed
Commit faecd17
Started Apr 19, 2022 10:17 PM
Ended Apr 19, 2022 10:31 PM
Duration 14:12 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 ... > no status when request isnt forced 404

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ZachJW34 ZachJW34 merged commit 48ebe64 into 10.0-release Apr 19, 2022
@ZachJW34 ZachJW34 deleted the zachw/add-dev-server-deps-original branch April 19, 2022 22:46
tgriesser added a commit that referenced this pull request Apr 20, 2022
…e-config

* 10.0-release:
  chore: Move component-index generation to scaffold-config package (#21090)
  fix: label text should be clickable to toggle snapshot highlight (#21122)
  feat: add next preset to webpack-dev-server-fresh (#21069)
  chore: add dev-servers as deps to server to be included in the binary (#21142)
  fix: do not highlight preExtension if selected option is renameFolder (#21121)
  fix(unify): Remove 'Reconfigure' dropdown from Testing Type chooser (#21063)
  feat(unify): launchpad header breadcrumbs and reusable tooltip component (#20648)
  test: add windows-test-kitchensink job (#20847)
  fix: aut centering and height calculation (#21019)
  chore: fix tests that fail on windows (#21055)
  fix: running a new test after already having run tests (#21087)
  fix: ct project setup framework keys for next and nuxt (#21116)
  fix: remove MountReturn from scaffolded ct support file (#21119)
  fix: do not scaffold fixtures if folder exist (#21078)
  fix: revert "fix: types for Cypress.Commands.add (#20376)" (#21104)
  chore: Update Chrome (stable) to 100.0.4896.127 and Chrome (beta) to 101.0.4951.34 (#21083)
  fix: types for Cypress.Commands.add (#20376) (#20377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants