Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACI tooltip updates #22345

Conversation

mike-plummer
Copy link
Contributor

Addresses updates to the Figma designs for ACI tooltips

  • Minor updates to copy
  • Fix issue with link uppercase/lowercase
  • Add support for 'access requested' state
  • Replace login state icon

User facing changelog

See referenced designs: https://cypressio.slack.com/archives/C035VB3HVAL/p1655305954209379

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

* Replace login icon
* Update i18n strings
* Add more component tests and improve test styling
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 15, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 15, 2022



Test summary

37553 0 454 0Flakiness 3


Run details

Project cypress
Status Passed
Commit bd00d04
Started Jun 15, 2022 7:26 PM
Ended Jun 15, 2022 7:44 PM
Duration 18:22 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

e2e/origin/validation.cy.ts Flakiness
1 cy.origin > successes > uses cy.origin twice
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@MuazOthman MuazOthman merged commit 2ad1c35 into muaz/CLOUD-577-spec-list-display-latest-runs Jun 16, 2022
@MuazOthman MuazOthman deleted the mikep/CLOUD-577-tooltip-updates branch June 16, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants