-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update ACI tooltip copy #22427
feat: Update ACI tooltip copy #22427
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look okay, but you've got some e2e test failures. See settings.cy.ts
@mike-plummer beat you to it 😉 should be fixed in my last commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Only comment is the discrepancy between sometimes saying "the Dashboard" and other times "the Cypress Dashboard". I saw y'all were discussing that earlier so I'll assume everyone is on board with it as-is
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
"errorNotLoggedInButton": "Log in to Cypress Dashboard" | ||
"errorNotLoggedInButton": "Log in to the Cypress Dashboard" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to figure out where this is used - can't find usages of errorNotLoggedInButton
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mike-plummer @marktnoonan if you have any knowledge of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like several of these strings aren't referenced (most of the error*
entries under recordKey
anyways)
User facing changelog
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?