Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update ACI tooltip copy #22427

Conversation

pstakoun
Copy link
Contributor

  • Closes

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 21, 2022

Thanks for taking the time to open a PR!

Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay, but you've got some e2e test failures. See settings.cy.ts

@pstakoun
Copy link
Contributor Author

pstakoun commented Jun 21, 2022

Changes look okay, but you've got some e2e test failures. See settings.cy.ts

@mike-plummer beat you to it 😉 should be fixed in my last commit

Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Only comment is the discrepancy between sometimes saying "the Dashboard" and other times "the Cypress Dashboard". I saw y'all were discussing that earlier so I'll assume everyone is on board with it as-is

@cypress
Copy link

cypress bot commented Jun 21, 2022



Test summary

37553 0 454 0Flakiness 7


Run details

Project cypress
Status Passed
Commit 462d9cf
Started Jun 21, 2022 6:37 PM
Ended Jun 21, 2022 6:54 PM
Duration 16:34 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
commands/net_stubbing.cy.ts Flakiness
1 network stubbing > waiting and aliasing > should handle aborted requests
next.cy.ts Flakiness
1 Working with next-12 > should detect new spec
e2e/origin/commands/actions.cy.ts Flakiness
1 cy.origin actions > #consoleProps > .selectFile()
commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

"errorNotLoggedInButton": "Log in to Cypress Dashboard"
"errorNotLoggedInButton": "Log in to the Cypress Dashboard"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to figure out where this is used - can't find usages of errorNotLoggedInButton.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mike-plummer @marktnoonan if you have any knowledge of this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like several of these strings aren't referenced (most of the error* entries under recordKey anyways)

@pstakoun pstakoun merged commit d8f8b15 into muaz/CLOUD-577-spec-list-display-latest-runs Jun 21, 2022
@pstakoun pstakoun deleted the peter/feat/tooltip-copy-updates branch June 21, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants