Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update ACI tooltip copy #22427

Merged
merged 2 commits into from
Jun 21, 2022
Merged

feat: Update ACI tooltip copy #22427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37f213d
feat: Update ACI tooltip copy
pstakoun Jun 21, 2022
462d9cf
Fix test
pstakoun Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/app/cypress/e2e/specs_list_latest_runs.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ describe('ACI - Latest runs and Average duration', { viewportWidth: 1200, viewpo

it('shows correct tooltips with log in buttons', () => {
cy.findByTestId('latest-runs-header').trigger('mouseenter')
cy.contains('.v-popper__popper--shown', 'View the status of your latest runs in the Cypress Dashboard')
cy.get('.v-popper__popper--shown button').should('have.text', 'Log in to Cypress Dashboard').click()
cy.contains('.v-popper__popper--shown', 'Connect to the Cypress Dashboard to see the status of your latest runs')
cy.get('.v-popper__popper--shown button').should('have.text', 'Log in to the Dashboard').click()
cy.findByRole('dialog', { name: 'Log in to Cypress' }).within(() => {
cy.get('button').contains('Log In')
cy.get('[aria-label="Close"]').click()
Expand All @@ -198,8 +198,8 @@ describe('ACI - Latest runs and Average duration', { viewportWidth: 1200, viewpo
cy.findByTestId('latest-runs-header').trigger('mouseleave')

cy.findByTestId('average-duration-header').trigger('mouseenter')
cy.contains('.v-popper__popper--shown', 'View the average spec durations of your latest runs in the Cypress Dashboard')
cy.get('.v-popper__popper--shown button').should('have.text', 'Log in to Cypress Dashboard').click()
cy.contains('.v-popper__popper--shown', 'Connect to the Cypress Dashboard to see the average spec durations of your latest runs')
cy.get('.v-popper__popper--shown button').should('have.text', 'Log in to the Dashboard').click()
cy.findByRole('dialog', { name: 'Log in to Cypress' }).within(() => {
cy.get('button').contains('Log In')
cy.get('[aria-label="Close"]').click()
Expand All @@ -226,7 +226,7 @@ describe('ACI - Latest runs and Average duration', { viewportWidth: 1200, viewpo

it('shows correct tooltips with log in buttons', () => {
cy.findByTestId('latest-runs-header').trigger('mouseenter')
cy.contains('.v-popper__popper--shown', 'View the status of your latest runs in the Cypress Dashboard')
cy.contains('.v-popper__popper--shown', 'Connect to the Cypress Dashboard to see the status of your latest runs')
cy.get('.v-popper__popper--shown button').should('have.text', 'Connect your project').click()
cy.findByRole('dialog', { name: 'Create project' }).within(() => {
cy.get('[aria-label="Close"]').click({ force: true })
Expand All @@ -235,7 +235,7 @@ describe('ACI - Latest runs and Average duration', { viewportWidth: 1200, viewpo
cy.findByTestId('latest-runs-header').trigger('mouseleave')

cy.findByTestId('average-duration-header').trigger('mouseenter')
cy.contains('.v-popper__popper--shown', 'View the average spec durations of your latest runs in the Cypress Dashboard')
cy.contains('.v-popper__popper--shown', 'Connect to the Cypress Dashboard to see the average spec durations of your latest runs')
cy.get('.v-popper__popper--shown button').should('have.text', 'Connect your project').click()
cy.findByRole('dialog', { name: 'Create project' }).within(() => {
cy.get('[aria-label="Close"]').click({ force: true })
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/specs/SpecHeaderCloudDataTooltip.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
>
<div
:class="{'m-2': projectConnectionStatus!== 'CONNECTED'}"
class="max-w-210px"
class="max-w-235px"
>
<i18n-t
scope="global"
Expand Down
12 changes: 6 additions & 6 deletions packages/frontend-shared/src/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@
"headerShort": "Runs",
"tooltip": {
"connected": "The {0} in the Cypress Dashboard",
"notConnected": "View the {0} in the Cypress Dashboard",
"noAccess": "Request access to view the {0} in the Cypress Dashboard",
"notConnected": "Connect to the Cypress Dashboard to see the {0}",
"noAccess": "Request access to this project in the Cypress Dashboard to view the {0}",
"linkText": "status of your latest runs"
}
},
Expand All @@ -145,13 +145,13 @@
"headerShort": "Duration",
"tooltip": {
"connected": "The {0} of your latest runs in the Cypress Dashboard",
"notConnected": "View the {0} of your latest runs in the Cypress Dashboard",
"noAccess": "Request access to view the {0} of your latest runs in the Cypress Dashboard",
"notConnected": "Connect to the Cypress Dashboard to see the {0} of your latest runs",
"noAccess": "Request access to this project in the Cypress Dashboard to view the {0} of your latest runs",
"linkText": "average spec durations"
}
},
"connectProjectButton": "Connect your project",
"dashboardLoginButton": "Log in to Cypress Dashboard",
"dashboardLoginButton": "Log in to the Dashboard",
"reconnectProjectButton": "Reconnect your project",
"requestAccessButton": "Request access",
"requestSentButton": "Request sent",
Expand Down Expand Up @@ -426,7 +426,7 @@
"errorNotFound": "Project not found",
"errorNotFoundButton": "Connect it again",
"errorNotLoggedIn": "You are not connected to the Cypress Dashboard",
"errorNotLoggedInButton": "Log in to Cypress Dashboard"
"errorNotLoggedInButton": "Log in to the Cypress Dashboard"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to figure out where this is used - can't find usages of errorNotLoggedInButton.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mike-plummer @marktnoonan if you have any knowledge of this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like several of these strings aren't referenced (most of the error* entries under recordKey anyways)

},
"project": {
"title": "Project Settings",
Expand Down