Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change some skipped tests to use retries #24124

Merged
merged 36 commits into from
Dec 20, 2022
Merged

test: change some skipped tests to use retries #24124

merged 36 commits into from
Dec 20, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Oct 5, 2022

  • Closes

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 5, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Oct 5, 2022



Test summary

199 0 23 0Flakiness 4


Run details

Project cypress
Status Passed
Commit 3a5b016
Started Dec 20, 2022 1:18 AM
Ended Dec 20, 2022 1:34 AM
Duration 15:58 💡
OS Windows 10.0.17763
Browser Chrome 108

View run in Cypress Dashboard ➡️


Flakiness

cypress\e2e\migration.cy.ts Flakiness
1 Full migration flow for each project > completes journey for migration-e2e-component-default-with-types
cypress\e2e\scaffold-component-testing.cy.ts Flakiness
1 scaffolding component testing > create-react-app > scaffolds component testing for Create React App v5 project
2 scaffolding component testing > angular-cli-unconfigured > scaffolds component testing for Angular
3 scaffolding component testing > svelte-webpack-unconfigured > Scaffolds component testing for Svelte using webpack

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review October 5, 2022 18:09
@rachelruderman
Copy link
Contributor

Thank you for implementing this!!! Definitely preferable to boost retries where possible than to skip altogether. I see some CI is failing, is that expected? Ideally the changes would keep CI green (unless there's unrelated CI failures happening)

@flotwig
Copy link
Contributor Author

flotwig commented Oct 17, 2022

Ideally the changes would keep CI green (unless there's unrelated CI failures happening)

@rachelruderman it seems to be flake, but not flake that was touched by these changes

Copy link
Contributor

@rachelruderman rachelruderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!! Thank you for taking this on 🙏

@flotwig flotwig marked this pull request as draft November 8, 2022 20:42
@flotwig flotwig marked this pull request as ready for review December 12, 2022 19:32
@flotwig
Copy link
Contributor Author

flotwig commented Dec 12, 2022

Had to re-skip some of the retries, there's a full list in the OP comment. I think this is now at a good spot where it's not going to bring any flake/failures back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants