Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak splash screen verbiage #24981

Merged
merged 2 commits into from Dec 5, 2022
Merged

Conversation

emilyrohrbough
Copy link
Member

Tweak Welcome Page verbiage per changelog feedback. Be explicit and less technical. That's what blogs are for 馃槃

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 5, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 5, 2022



Test summary

24848 1 2490 0Flakiness 25


Run details

Project cypress
Status Failed
Commit 3842ea1
Started Dec 5, 2022 10:25 PM
Ended Dec 5, 2022 10:43 PM
Duration 18:25 馃挕
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard 鉃★笍


Failures

cypress/e2e/e2e/origin/user_agent_override.cy.ts 1聽Failed
1 user agent override > persists modified user agent after cy.go

Flakiness

runs.cy.ts 1聽Flakiness
1 App: Runs > Runs - Login > clicking the login button will open the login modal
e2e/origin/cookie_behavior.cy.ts 4聽Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
This comment includes only the first 5 flaky tests. See all 25 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@emilyrohrbough emilyrohrbough changed the title chore: tweak splashscreen verbiage chore: tweak splash screen verbiage Dec 5, 2022
@emilyrohrbough emilyrohrbough merged commit 166bf8e into develop Dec 5, 2022
@emilyrohrbough emilyrohrbough deleted the update-splashscreen branch December 5, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants