-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: set min widths for icons #25684
Changes from 3 commits
410e89b
2078ae9
3deb94d
f22112f
0c23ee9
9790501
1c15f43
b8166e8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ | |
size="16" | ||
status="failed" | ||
data-cy="failed-icon" | ||
class="isolate" | ||
class="min-w-16px isolate" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did not test this, but I think another option that would work is to use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that would work just fine too. Ideally we'll handle this in the design system. What do you think @elevatebart? Default min width to match the icon size and prevent shrinkage? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am with @warrensplayer on this one. If we want to avoid shrinking, it's better to use |
||
/> | ||
<template | ||
v-for="{text, type}, index in failedTestData.mappedTitleParts" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12.5.1 has already been released, you should create a new entry (I've been doing
12.6.0
since there are a few features in the queue that should be merged by next week.You can reference 3c2b36d