Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix issue with logs without wallClockStartedAt #26473

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Apr 10, 2023

Additional details

  • If the log wasn't created with a wallClockStartedAt (e.g. an agent log), the wallClockUpdatedAt value will now default to the current date/time.

Steps to test

  • Run the spies_stubs_clocks.cy.js scaffold test and verify no schema errors are thrown.

How has the user experience changed?

PR Tasks

@mschile mschile changed the title chore: fix issue with logs without wallClockUpdatedAt chore: fix issue with logs without wallClockStartedAt Apr 10, 2023
@cypress
Copy link

cypress bot commented Apr 11, 2023

6 flaky tests on run #45469 ↗︎

0 4306 889 0 Flakiness 6

Details:

chore: fix issue with logs without wallClockUpdatedAt
Project: cypress Commit: 237f3f275c
Status: Passed Duration: 15:37 💡
Started: Apr 11, 2023 9:26 PM Ended: Apr 11, 2023 9:42 PM
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
... > with `times` > only uses each handler N times Output Video
... > stops waiting when an xhr request is canceled Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mschile mschile merged commit 9c5fffb into feat/protocol Apr 11, 2023
@mschile mschile deleted the mschile/protocol/command_log_updated_at branch April 11, 2023 21:52
tgriesser added a commit that referenced this pull request Apr 25, 2023
* feat/protocol: (45 commits)
  chore: adding support for url:changed (#26519)
  chore: adding viewport:changed to protocol (#26508)
  chore: Reduce dependencies and binary size, add circle ci detector (#26522)
  chore: 12.10.0 release (#26517)
  test: fix flaky tests (#26505)
  chore: Check project dependencies for CT compatibility (#26497)
  chore: update vm2 to 3.9.16 (#26489)
  chore: enable builds on feat/protocol branch (#26506)
  chore: [skip ci] update to labels looked at by stalebot (#26496)
  chore: connecting to electron browser (#26471)
  chore: [skip ci] turning on stale bot (#26488)
  chore: fix issue with logs without wallClockUpdatedAt (#26473)
  Update triage_add_to_project.yml
  chore: Update Chrome (stable) to 112.0.5615.49 and Chrome (beta) to 113.0.5672.24 (#26434)
  feat: display framework definition errors (#26183)
  fix: correctly resolve dependencies for CT onboarding when using Yarn Plug n Play (#26452)
  fix: Subscribe to framework detection changes in wizard (#26437)
  fix: make clicks on type('{enter}') composed (#26395)
  chore: update add-to-project workflow (#26439)
  chore: Pass telemetry resources from the node process to the browser (#26468)
  ...
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants