chore: Reduce dependencies and binary size, add circle ci detector #26522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhenkes
commented
Apr 17, 2023
| @@ -493,7 +493,6 @@ commands: | |||
| # internal PR | |||
| CYPRESS_RECORD_KEY=$MAIN_RECORD_KEY \ | |||
| CYPRESS_INTERNAL_ENABLE_TELEMETRY="true" \ | |||
| OTEL_RESOURCE_ATTRIBUTES="ci.branch=$CIRCLE_BRANCH,ci.job=$CIRCLE_JOB,ci.node-index=$CIRCLE_NODE_INDEX,ci.circle=$CIRCLECI,ci.build-url=$CIRCLE_BUILD_URL,ci.build-number=$CIRCLE_BUILD_NUM" \ | |||
There was a problem hiding this comment.
the circle ci detector replaces the need for this line
mjhenkes
commented
Apr 17, 2023
| @@ -16,13 +16,14 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@opentelemetry/api": "1.4.1", | |||
| "@opentelemetry/auto-instrumentations-node": "0.36.4", | |||
There was a problem hiding this comment.
specifically we don't need this dep
mjhenkes
commented
Apr 17, 2023
| @@ -16,13 +16,14 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@opentelemetry/api": "1.4.1", | |||
| "@opentelemetry/auto-instrumentations-node": "0.36.4", | |||
| "@opentelemetry/exporter-trace-otlp-http": "0.36.1", | |||
| "@opentelemetry/instrumentation": "0.36.1", | |||
mjhenkes
commented
Apr 17, 2023
Comment on lines
+204
to
+205
| path.join(buildAppDir, '**', '@openTelemetry', '**', 'esm'), | ||
| path.join(buildAppDir, '**', '@openTelemetry', '**', 'esnext'), |
There was a problem hiding this comment.
these lines remove the esm and esnext folders from open telemetry, we don't use them.
emilyrohrbough
approved these changes
Apr 17, 2023
AtofStryker
reviewed
Apr 17, 2023
|
|
||
| afterEach(() => { | ||
| // Replace values | ||
| process.env.CIRCLECI = processValues.CIRCLECI |
There was a problem hiding this comment.
Does this condition need to be reversed so we delete the circle process variables so they don't leak out to other tests in the process?
There was a problem hiding this comment.
this is the reversing, we cache the values, delete them, then reset them to the cache
There was a problem hiding this comment.
Ah that makes a lot of sense now 😅
Co-authored-by: Bill Glesias <bglesias@gmail.com>
AtofStryker
approved these changes
Apr 17, 2023
28 flaky tests on run #45595 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > establishes foobar spec bridge |
Output
Video
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
Video
|
|
| ... > correctly returns currentRetry |
Output
Video
|
|
| ... > correctly returns currentRetry |
Output
Video
|
|
The first 5 flaky specs are shown, see all 16 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
astone123
pushed a commit
to kgroat/cypress
that referenced
this pull request
Apr 19, 2023
…ypress-io#26522) * chore: add circle ci detector * update deps * adjust deps and cleanup binary? * Add Tests * fix tests, keep artifact * Apply suggestions from code review Co-authored-by: Bill Glesias <bglesias@gmail.com> --------- Co-authored-by: Bill Glesias <bglesias@gmail.com>
tgriesser
added a commit
that referenced
this pull request
Apr 25, 2023
* feat/protocol: (45 commits) chore: adding support for url:changed (#26519) chore: adding viewport:changed to protocol (#26508) chore: Reduce dependencies and binary size, add circle ci detector (#26522) chore: 12.10.0 release (#26517) test: fix flaky tests (#26505) chore: Check project dependencies for CT compatibility (#26497) chore: update vm2 to 3.9.16 (#26489) chore: enable builds on feat/protocol branch (#26506) chore: [skip ci] update to labels looked at by stalebot (#26496) chore: connecting to electron browser (#26471) chore: [skip ci] turning on stale bot (#26488) chore: fix issue with logs without wallClockUpdatedAt (#26473) Update triage_add_to_project.yml chore: Update Chrome (stable) to 112.0.5615.49 and Chrome (beta) to 113.0.5672.24 (#26434) feat: display framework definition errors (#26183) fix: correctly resolve dependencies for CT onboarding when using Yarn Plug n Play (#26452) fix: Subscribe to framework detection changes in wizard (#26437) fix: make clicks on type('{enter}') composed (#26395) chore: update add-to-project workflow (#26439) chore: Pass telemetry resources from the node process to the browser (#26468) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This cleans up our open telemetry dependencies (which i should have done before the last pr) it also reduces the size of the open telemetry modules included in the binary from 9.7 mb to 2.4 mb
Steps to test
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?