Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update angular dep min versions #26908

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

jordanpowell88
Copy link
Collaborator

@jordanpowell88 jordanpowell88 commented Jun 1, 2023

Additional details

Currently the minVersions of dependencies for ANGULAR have a bug in the string interpolation.

Steps to test

Launch Cypress in an Angular 16 project

How has the user experience changed?

Before
Screenshot 2023-06-01 at 12 42 32 PM

After
Screenshot 2023-06-01 at 12 43 43 PM

PR Tasks

@jordanpowell88 jordanpowell88 requested a review from a team June 1, 2023 17:00
@cypress
Copy link

cypress bot commented Jun 1, 2023

9 flaky tests on run #47092 ↗︎

0 5659 83 0 Flakiness 9

Details:

chore: remove whitespace
Project: cypress Commit: ec5a3ad6db
Status: Passed Duration: 13:40 💡
Started: Jun 5, 2023 7:31 PM Ended: Jun 5, 2023 7:45 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
Flakiness  runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video

The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@MikeMcC399
Copy link
Contributor

I successfully checked this PR against an updated Angular 16 project:

git clone https://github.com/cypress-io/cypress-component-testing-apps
cd cypress-component-testing-apps/angular
git switch -c angular-16
npm ci
ng update @angular/cli @angular/core

then yarn start and test project with Component Testing.

@lmiller1990 lmiller1990 requested a review from a team June 5, 2023 06:09
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordanpowell88

Will you fix the release version number in the CHANGELOG? Or is 12.14.0 correct?

@jordanpowell88 jordanpowell88 merged commit 084f054 into develop Jun 5, 2023
2 of 3 checks passed
@jordanpowell88 jordanpowell88 deleted the jordanpowell88/fix-angular-deps branch June 5, 2023 19:58
@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jun 5, 2023

beta verification

Was successful!

On Ubuntu 22.04

mkdir cy-angular-ct
cd cy-angular-ct
git init
npm init -y
npm install https://cdn.cypress.io/beta/npm/12.13.1/linux-x64/develop-084f05482c26281c09ca287f767943990f2d5573/cypress.tgz -D
npx cypress open

Click on "Component Testing"
Select Front-end framework Angular
Click "Next step"
Copy and paste the command as instructed:
npm install -D @angular/cli @angular-devkit/build-angular @angular/core @angular/common @angular/platform-browser-dynamic
Status is updated to:
"You've successfully installed all required dependencies." 👍🏻

cc: @Timbo1979

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 7, 2023

Released in 12.14.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.14.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 16 not detected by CT
4 participants