chore: add mountVersion to props passed to protocol setup #27645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 flaky tests on run #50399 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Output
Screenshots
|
|
commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
|
| network stubbing > intercepting response > can delay and throttle a static response |
Output
|
|
The first 5 flaky specs are shown, see all 22 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
AtofStryker
approved these changes
Aug 24, 2023
| @@ -2890,88 +2890,6 @@ exports['e2e record capture-protocol enabled passing retrieves the capture proto | |||
| Recorded Run: https://dashboard.cypress.io/projects/cjvoj7/runs/12 | |||
|
|
|||
|
|
|||
| ` | |||
There was a problem hiding this comment.
Was this one expected to be removed? I didn't see any changes to record_spec.js.
There was a problem hiding this comment.
I don't either, but it also doesn't match any tests in record_spec. I'm guessing it was an obsolete snapshot that didn't get removed on a previous merge.
There was a problem hiding this comment.
Sounds good. Good to clean it up then.
ryanthemanuel
approved these changes
Aug 24, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In order to add mountVersion to metadata saved to the protocol db, we're passing it in to the AppCaptureProtocol constructor.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?