Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in CONTRIBUTING.md #27705

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

Crustum7
Copy link
Contributor

@Crustum7 Crustum7 commented Aug 30, 2023

Additional details

na

Steps to test

na

How has the user experience changed?

na

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@cypress
Copy link

cypress bot commented Aug 30, 2023

25 flaky tests on run #50662 ↗︎

0 28100 1355 0 Flakiness 25

Details:

docs: fix typo in CONTRIBUTING.md
Project: cypress Commit: 1ab491ea56
Status: Passed Duration: 18:52 💡
Started: Aug 30, 2023 3:39 PM Ended: Aug 30, 2023 3:58 PM
Flakiness  cypress-in-cypress.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config Test Replay Output Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Output Screenshots
Flakiness  commands/querying/querying.cy.js • 2 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > throws after timing out after a .wait() alias reference Test Replay Output
... > throws when alias property isnt a digit or `all` Test Replay Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
... > correctly returns currentRetry Test Replay Output
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output

The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.

Review all test suite changes for PR #27705 ↗︎

@Crustum7
Copy link
Contributor Author

Crustum7 commented Sep 1, 2023

Do I need to write a message to make the tests run again? I'm not authorized to do so in CircleCI

@Crustum7
Copy link
Contributor Author

Crustum7 commented Sep 1, 2023

I want to run the tests again because my co-author just signed the CLA. I think that was the issue

@AtofStryker
Copy link
Contributor

@Crustum7 I have to kick the build off for you, which it should now be running.

Co-authored-by: Simon Törnqvist <simon.thornqvist99@gmail.com>
@jaffrepaul jaffrepaul requested review from jaffrepaul and removed request for jaffrepaul September 7, 2023 13:36
@nagash77 nagash77 merged commit 86d8b96 into cypress-io:develop Sep 8, 2023
5 of 8 checks passed
@nagash77 nagash77 removed their assignment Sep 8, 2023
@S-Tornqvist S-Tornqvist deleted the issue-5452 branch September 13, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typo in CONTRIBUTING.md
5 participants