Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in CONTRIBUTING.md #27708

Closed
S-Tornqvist opened this issue Aug 30, 2023 · 3 comments · Fixed by #27705
Closed

Fix typo in CONTRIBUTING.md #27708

S-Tornqvist opened this issue Aug 30, 2023 · 3 comments · Fixed by #27705

Comments

@S-Tornqvist
Copy link
Contributor

S-Tornqvist commented Aug 30, 2023 •
edited
Loading

Subject

Guides (CONTRIBUTING.md)

Description

The sentence "If you make changes to an npm package that can't be published until the binary is also updated, you should make a pull request against specifying this is not be merged until the scheduled Cypress app release date." in file CONTRIBUTING.md is hard to understand because of incorrect grammar.
@Crustum7 Crustum7 mentioned this issue Aug 30, 2023
Merged
@S-Tornqvist
Copy link
Contributor Author

Related to documentation issue 5452

@jennifer-shehane
Copy link
Member

@S-Tornqvist We're open to a Pull Request if you want to fix the language in the Contributing guide.

@MikeMcC399
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix typo in CONTRIBUTING.md S-Tornqvist/cypress
3 participants
@jennifer-shehane @S-Tornqvist @MikeMcC399