misc: capture Semaphore PR number #29314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
This env var is documented here: https://docs.semaphoreci.com/ci-cd-environment/environment-variables/#semaphore_git_pr_number
|
@estrada9166 Can you add a changelog entry as outlined in this guide? https://github.com/cypress-io/cypress/blob/develop/guides/writing-the-cypress-changelog.md#writing-guidelines |
jennifer-shehane
changed the title
Passing run #54953 ↗︎
Details:
Review all test suite changes for PR #29314 ↗︎ |
|||||||||||||||
AtofStryker
approved these changes
Apr 12, 2024
mschile
reviewed
Apr 12, 2024
mschile
approved these changes
Apr 12, 2024
|
I wonder if next version is failing due to my entry of 13.8.0 in #29306r or if the semantic commit job thinks MISC is a feature bump? My guess is the later |
jennifer-shehane
requested changes
Apr 12, 2024
|
@AtofStryker Maybe it's failing because the initial commit was prefixed with |
jennifer-shehane
approved these changes
Apr 15, 2024
jennifer-shehane
approved these changes
Apr 15, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Capture Semaphore PR number to correctly display it on the cloud
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?