Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: capture Semaphore PR number #29314

Merged
merged 8 commits into from Apr 15, 2024
Merged

misc: capture Semaphore PR number #29314

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3564bcd
feat: capture Semaphore PR number
estrada9166 Apr 11, 2024
d813a8d
Update changelog
estrada9166 Apr 11, 2024
102bbb5
Merge branch 'develop' into alejandro/feat/capture-semaphore-pr-number
jennifer-shehane Apr 11, 2024
7b15695
Update cli/CHANGELOG.md
mschile Apr 12, 2024
82e1c49
Merge branch 'develop' into alejandro/feat/capture-semaphore-pr-number
estrada9166 Apr 12, 2024
d60857f
Fix test
estrada9166 Apr 12, 2024
8818040
Update cli/CHANGELOG.md
jennifer-shehane Apr 12, 2024
be0e60f
Update cli/CHANGELOG.md
jennifer-shehane Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
@@ -1,4 +1,12 @@
<!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
## 13.7.4
jennifer-shehane marked this conversation as resolved.
Show resolved Hide resolved

_Released 4/16/2024 (PENDING)_

**Misc:**

- We now capture the [Semaphore](https://semaphoreci.com/) CI provider's environment variable [`SEMAPHORE_GIT_PR_NUMBER`](https://docs.semaphoreci.com/ci-cd-environment/environment-variables/#semaphore_git_pr_number) to display the linked PR number in the Cloud. Addressed in [#29314](https://github.com/cypress-io/cypress/pull/29314).

## 13.7.3

_Released 4/11/2024_
Expand Down
1 change: 1 addition & 0 deletions packages/server/lib/util/ci_provider.js
View file
Open in desktop
Expand Up @@ -340,6 +340,7 @@ const _providerCiParams = () => {
'SEMAPHORE_EXECUTABLE_UUID',
'SEMAPHORE_GIT_BRANCH',
'SEMAPHORE_GIT_DIR',
'SEMAPHORE_GIT_PR_NUMBER',
'SEMAPHORE_GIT_REF',
'SEMAPHORE_GIT_REF_TYPE',
'SEMAPHORE_GIT_REPO_SLUG',
Expand Down
2 changes: 2 additions & 0 deletions packages/server/test/unit/util/ci_provider_spec.js
View file
Open in desktop
Expand Up @@ -904,6 +904,7 @@ describe('lib/util/ci_provider', () => {
SEMAPHORE_GIT_BRANCH: 'show-semaphore-v2-266',
SEMAPHORE_GIT_WORKING_BRANCH: 'show-semaphore-v2-266',
SEMAPHORE_GIT_DIR: 'cypress-example-kitchensink',
SEMAPHORE_GIT_PR_NUMBER: '1',
SEMAPHORE_GIT_REF: 'refs/heads/show-semaphore-v2-266',
SEMAPHORE_GIT_REF_TYPE: 'branch',
SEMAPHORE_GIT_REPO_SLUG: 'cypress-io/cypress-example-kitchensink',
Expand Down Expand Up @@ -937,6 +938,7 @@ describe('lib/util/ci_provider', () => {
semaphoreGitBranch: 'show-semaphore-v2-266',
semaphoreGitWorkingBranch: 'show-semaphore-v2-266',
semaphoreGitDir: 'cypress-example-kitchensink',
semaphoreGitPrNumber: '1',
semaphoreGitRef: 'refs/heads/show-semaphore-v2-266',
semaphoreGitRefType: 'branch',
semaphoreGitRepoSlug: 'cypress-io/cypress-example-kitchensink',
Expand Down