-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add experimentalMemoryManagement flag to our cy-in-cy App tests #29359
Conversation
if [[ <<parameters.package>> == 'app' && <<parameters.type>> == 'e2e' ]]; then | ||
export DEBUG=cypress:* | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these DEBUG flag from windows because I couldn't see if the errors were legitimate or not with the debug on (they were not)
Merging with windows flake - this is known on the project-setup: https://cloud.cypress.io/projects/ypt4pf/runs/55073/overview/7b5ffde2-f041-47a5-8c8d-348562df0b39/replay?roarHideRunsWithDiffGroupsAndTags=1&ts=1713806090740.454&att=1 |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Close #29357
Additional details
This PR sets
experimentalMemoryManagement
totrue
for our internal app tests. Our internal App tests run cypress within cypress, which is a unique situation that our users don't encounter. The memory used in Chrome was causing this job to crash Chrome frequently.I don't see a large increase in the time to run these tests, maybe an increase of ~20-30 secs in linux and windows. I suspect they'll be more stable though.
Additionally, this PR upgrades the resource class used to run
run-app-integration-tests-chrome
job to large from medium. The medium resource class was always maxing out at 100% CPU.Before
https://app.circleci.com/pipelines/github/cypress-io/cypress/61043/workflows/b0bfd961-3476-4450-9916-36d299560584/jobs/2538781/resources
After
https://app.circleci.com/pipelines/github/cypress-io/cypress/61054/workflows/fe25bb31-be6e-46b8-95ce-3bd72d1ea068/jobs/2538662/resources
Steps to test
Tests should pass. I also ran this on Windows jobs.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?