Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add experimentalMemoryManagement flag to our cy-in-cy App tests #29359

Merged
merged 7 commits into from
Apr 22, 2024
Merged

chore: Add experimentalMemoryManagement flag to our cy-in-cy App tests #29359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b817808
chore: Add experimentalMemoryManagement flag to our cy-in-cy App tests
jennifer-shehane Apr 18, 2024
ebcc7f2
empty commit
jennifer-shehane Apr 18, 2024
1ebf81e
have extra workflows run
jennifer-shehane Apr 18, 2024
c846ff8
bump up the resources for the app tests on chrome also
jennifer-shehane Apr 18, 2024
dcc95ab
Merge branch 'develop' into app-mem-mng-flag
jennifer-shehane Apr 19, 2024
9052a24
Merge branch 'develop' into app-mem-mng-flag
jennifer-shehane Apr 19, 2024
70fe613
removed debug logs in windows
jennifer-shehane Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions .circleci/workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@ mainBuildFilters: &mainBuildFilters
- develop
- /^release\/\d+\.\d+\.\d+$/
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- 'cacie/dep/electron-27'
- 'feat/protocol_shadow_dom_support'
- 'app-mem-mng-flag'
- 'publish-binary'
- 'em/circle2'

# usually we don't build Mac app - it takes a long time
# but sometimes we want to really confirm we are doing the right thing
Expand All @@ -43,9 +41,7 @@ macWorkflowFilters: &darwin-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'cacie/dep/electron-27', << pipeline.git.branch >> ]
- equal: [ 'feat/protocol_shadow_dom_support', << pipeline.git.branch >> ]
- equal: [ 'feat/support_wds5', << pipeline.git.branch >> ]
- equal: [ 'app-mem-mng-flag', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand All @@ -56,9 +52,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'cacie/dep/electron-27', << pipeline.git.branch >> ]
- equal: [ 'feat/support_wds5', << pipeline.git.branch >> ]
- equal: [ 'em/circle2', << pipeline.git.branch >> ]
- equal: [ 'app-mem-mng-flag', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand All @@ -81,10 +75,7 @@ windowsWorkflowFilters: &windows-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'cacie/dep/electron-27', << pipeline.git.branch >> ]
- equal: [ 'feat/protocol_shadow_dom_support', << pipeline.git.branch >> ]
- equal: [ 'lerna-optimize-tasks', << pipeline.git.branch >> ]
- equal: [ 'feat/support_wds5', << pipeline.git.branch >> ]
- equal: [ 'app-mem-mng-flag', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand Down Expand Up @@ -672,9 +663,6 @@ commands:
echo Total containers $CIRCLE_NODE_TOTAL

if [[ -v MAIN_RECORD_KEY ]]; then
if [[ <<parameters.package>> == 'app' && <<parameters.type>> == 'e2e' ]]; then
export DEBUG=cypress:*
fi
Comment on lines -675 to -677
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these DEBUG flag from windows because I couldn't see if the errors were legitimate or not with the debug on (they were not)

# internal PR
cmd=$([[ <<parameters.percy>> == 'true' ]] && echo 'yarn percy exec --parallel -- --') || true

Expand Down Expand Up @@ -1860,7 +1848,7 @@ jobs:
<<: *defaultsParameters
resource_class:
type: string
default: medium
default: large
percy:
type: boolean
default: false
Expand Down
1 change: 1 addition & 0 deletions packages/app/cypress.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export default defineConfig({
reporterOptions: {
configFile: '../../mocha-reporter-config.json',
},
experimentalMemoryManagement: true,
experimentalCspAllowList: false,
experimentalInteractiveRunEvents: true,
component: {
Expand Down
Loading