-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrades http-proxy to prevent closed socket crash #29453
fix: upgrades http-proxy to prevent closed socket crash #29453
Conversation
If the socket is not open the write will fail and crash the server and cypress.
|
@JamesNimlos We talked a bit internally about using cypress/guides/patch-package.md Line 7 in f3bdb9f
|
Hi @JamesNimlos! Thank you for opening a pull request. What we have decided to do as a team is patch the |
Additional details
Steps to test
Reproduction steps are not concrete as this type of issue happens sporadically. This is a temporary validation of the changes introduced in cypress-io/node-http-proxy#1 to confirm they do not break existing proxy functionality and tests.
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
?type definitions
?