Handle lowercase environment variable names in proxy #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotwig
changed the title
brian-mann
approved these changes
Apr 3, 2019
laurinenas
pushed a commit
to laurinenas/cypress
that referenced
this pull request
Apr 28, 2019
* cli, server: check for lowercase environment variable too * server: clean up proxy.ts to not use this * rename to JS to prevent needing build process for tests to pass * enable implicit any * some cleanup, added tests around additional lowercased env vars Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3865 by copying all *_proxy vars to their *_PROXY environment counterparts on server startup.