Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency request-progress to version .x 馃専 #4584

Merged
merged 3 commits into from Jul 1, 2019

Conversation

2 participants
@renovate
Copy link
Contributor

commented Jun 27, 2019

This PR contains the following updates:

Package Type Update Change
request-progress dependencies major 0.4.0 -> 3.0.0

Release Notes

IndigoUnited/node-request-progress

v3.0.0

Compare Source

v2.0.1

Compare Source

v2.0.0

Compare Source

v1.0.2

Compare Source

v1.0.1

Compare Source

v1.0.0

Compare Source


Renovate configuration

馃搮 Schedule: "before 3am on the first day of the month" in timezone America/New_York.

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@jennifer-shehane jennifer-shehane self-assigned this Jun 27, 2019

@jennifer-shehane jennifer-shehane self-requested a review Jun 27, 2019

@jennifer-shehane jennifer-shehane removed their assignment Jun 27, 2019

@jennifer-shehane
Copy link
Member

left a comment

This actually changes how the percentages are printed, which seems to not be caught in a test at all. I had to manually download to check it, so...I'd like to maybe have at least a unit test for the percentage printing added.

Before update (it should display same as the Unzip percentage here):

Screen Shot 2019-06-27 at 9 08 19 PM

After update:

Screen Shot 2019-06-27 at 9 08 03 PM

jennifer-shehane added some commits Jun 28, 2019

Added method to utils to convert percent value to percentage
- Wrote unit tests for both calculateETA and the percent to percentage
conversion

@jennifer-shehane jennifer-shehane self-requested a review Jun 28, 2019

@jennifer-shehane
Copy link
Member

left a comment

  • request-progress now sends the 'percent' as a value between 0 and 1, so I had to write a method to convert that to percentage - so converting 0.498092 -> 50%
@renovate

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

PR has been edited

馃懛 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@jennifer-shehane jennifer-shehane merged commit a3daee1 into develop Jul 1, 2019

23 checks passed

ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: Mac build Your tests passed on CircleCI!
Details
ci/circleci: Mac lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-3x Your tests passed on CircleCI!
Details
ci/circleci: lint-typescript Your tests passed on CircleCI!
Details
ci/circleci: reporter-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-performance-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@renovate renovate bot deleted the renovate/request-progress-3.x branch Jul 1, 2019

@cypress-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

Released in 3.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.