New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade execa to 2.0.0 (which supports Node.js 8.0.0) #6513
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
If we really want to support Node 8.0.0 then let's add a test job in https://github.com/cypress-io/cypress-test-node-versions/blob/master/circle.yml (we can even use branch 4.1.0 there for now to test upcoming change) that installs Cypress on Node 8.0.0 - and we can quickly add |
@bahmutov Yes, Brian asked me to followup with having the test-node-versions support this. Right now I believe it pulls latest 8 version, which does currently work, it's lower versions of 8 that are busted. Issue here: cypress-io/cypress-test-node-versions#47 |
User facing changelog
execa
from3.0.0
to2.0.0
.Additional details
How has the user experience changed?
Should no longer see the errors below during install:
yarn
npm install