Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent cy.type from losing focus from element on blur #9254

merged 1 commit into from Nov 20, 2020


Copy link

@kuceb kuceb commented Nov 20, 2020

User facing changelog

Bug fix: fix issue causing cy.type to not type the entire string into the target element (regression from 3.5.0)

Additional details

  • this prevents issues with page loads / framework rerenders sometimes causing focus to be lost by an element mid-type, causing characters to be typed into the body instead of the input.
  • not a breaking change since this only affects typing when element is blurred mid-type, and cy.type will still follow focus mid-type unless the new element is body or null (element was blurred, no new element was focused)

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

Copy link

cypress-bot bot commented Nov 20, 2020

Thanks for taking the time to open a PR!

Copy link

cypress bot commented Nov 20, 2020

Test summary

3872 0 52 1

Run details

Project cypress
Status Passed
Commit 63d19c5
Started Nov 20, 2020 12:49 PM
Ended Nov 20, 2020 1:00 PM
Duration 11:26 💡
OS Linux Debian - 10.2
Browser Firefox 77

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor Author

kuceb commented Nov 20, 2020

failures unlrelated

Copy link

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good compromise to me, especially since there aren't a lot of use cases provided to us.

@kuceb kuceb merged commit 8fb3ad9 into develop Nov 20, 2020
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Cypress Doesn't Finish Typing Strings Before Continuing to Next Field
2 participants