Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opinionated rules #4

Closed
jbinto opened this issue Apr 24, 2018 · 3 comments
Closed

Add opinionated rules #4

jbinto opened this issue Apr 24, 2018 · 3 comments
Assignees
@chrisbreiding
Labels
type: enhancement

Comments

@jbinto
Copy link

jbinto commented Apr 24, 2018

Would be cool if this plugin could do things like warn on calls to .wait(), and enforce other Cypress best practices.
@chrisbreiding
Copy link
Contributor

That's a great idea. We've talked about in the past, just haven't taken the time to come up with the exact rules and implement them. I'll keep this open to track any progress we make.

@chrisbreiding chrisbreiding self-assigned this Apr 25, 2018
SaladFork added a commit to SaladFork/eslint-plugin-cypress that referenced this issue Oct 25, 2018
@SaladFork
Adds a recommended config with new no-assigning-return-values rule
2736f5d 
Adds an opinionated rule as suggested in cypress-io#4. Tries to help with the
"Assigning Return Values" Best Practice described in the guide:
  <https://docs.cypress.io/guides/references/best-practices.html#Assigning-Return-Values>
@SaladFork SaladFork mentioned this issue Oct 25, 2018
Merged
@SaladFork
Copy link
Contributor

SaladFork commented Oct 25, 2018 •
edited
Loading

warn on calls to .wait()

@jbinto do you mind elaborating on what you meant by this?

@SaladFork SaladFork mentioned this issue Oct 29, 2018
Merged
SaladFork added a commit to SaladFork/eslint-plugin-cypress that referenced this issue Nov 2, 2018
@SaladFork
Adds a recommended config with new no-assigning-return-values rule
74f592b 
Adds an opinionated rule as suggested in cypress-io#4. Tries to help with the
"Assigning Return Values" Best Practice described in the guide:
  <https://docs.cypress.io/guides/references/best-practices.html#Assigning-Return-Values>
jaffrepaul pushed a commit that referenced this issue Sep 27, 2022
@DamienCassou
Merge pull request #4 from foretagsplatsen/dependabot/npm_and_yarn/se…
7b340a0 
…mantic-release-19.0.3
@MikeMcC399
Copy link
Collaborator

This suggestion is implemented.

See

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbreiding chrisbreiding

Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SaladFork @chrisbreiding @jbinto @MikeMcC399