Adds a recommended config with new no-assigning-return-values rule #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an opinionated rule as suggested in #4. Tries to help with the "Assigning Return Values" Best Practice described in the guide, something that bit me when I was first trying out Cypress.
When writing the rules and the folder layout, I tried to follow the practices described in the ESLint guide. I also chose
jest
as the test runner but it can be easily switched to Mocha or whatever a maintainer would prefer.I also updated the readme to instruct on how to add the recommended config, as well as a list of rules and instructions for developing new rules.
Known shortcomings:
let
,const
,var
). However, it will not catch more complex assignment operations such as destructuring:let [a, b] = [true, cypress.get('foo')]
.Feedback/ideas on this or other potential rules welcome.
Example: