Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to run npm ci after NPM cache hit #11

Closed
bahmutov opened this issue Nov 12, 2019 · 1 comment · Fixed by #12
Closed

Need to run npm ci after NPM cache hit #11

bahmutov opened this issue Nov 12, 2019 · 1 comment · Fixed by #12
Labels
bug Something isn't working released

Comments

@bahmutov
Copy link
Contributor

Right now we are not installing NPM modules from ~/.npm to node_modules at all
@bahmutov bahmutov added the bug Something isn't working label Nov 12, 2019
bahmutov added a commit that referenced this issue Nov 12, 2019
@bahmutov
fix: run npm install, close #11
50e3ead
@bahmutov bahmutov mentioned this issue Nov 12, 2019
Merged
bahmutov added a commit that referenced this issue Nov 12, 2019
@bahmutov
feat: add start parameter (#12)
27f7433 
That starts local server or whatever is necessary to run in the background for tests to run. Example

```yml
name: With server
on: [push]
jobs:
  cypress-run:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v1
      # Install NPM dependencies, cache them correctly
      # and run all Cypress tests
      - name: Cypress run
        uses: cypress-io/github-action@v1
        with:
          start: npm start
```

- closes #8
- fixes #11 (run `npm ci`)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add start parameter cypress-io/github-action
1 participant
@bahmutov