Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Rename "nextState" to "transToNextState" in case it is not of type State #107

Open
cyrille-artho opened this issue Mar 24, 2021 · 7 comments
Labels
good first issue Good for newcomers

Comments

@cyrille-artho
Copy link
Owner

The current variable name, which appears independently in a few classes, is misleading if it refers to a transition (an instance of Transition or RecordedTransition instead of a state. Renaming this will prevent confusion.

@cyrille-artho cyrille-artho added the good first issue Good for newcomers label Mar 24, 2021
@KishkinJ10
Copy link

can i work on this ?? I am a beginner and i want to take part in GSoC 2021.

@cyrille-artho
Copy link
Owner Author

Yes, you are welcome to work on this.

KishkinJ10 added a commit to KishkinJ10/modbat that referenced this issue Mar 31, 2021
@KishkinJ10
Copy link

sir i have made a PR on this issue please check it,
as it will help me very much in my contributions as a beginner.

@cyrille-artho
Copy link
Owner Author

Hi,
I think it takes a while for Travis to report the build, so I have to wait a while before I can see if the code runs correctly.
You have renamed a bit more than I expected:

  • The changes in README are not needed, as the documentation there refers to states.
  • The classes themselves should not be renamed, just the variables (when referring to transitions).
  • nextStateNextIf should be kept as is, too.
    So please revert renamings in README in (at least) in all cases where something follows after nextState, as in nextStatePredicates, transToNextStateOfBacktrack, etc.
    The intention was to rename only plain nextState variables, and also only in the implementation code, not the documentation or examples.

@cyrille-artho
Copy link
Owner Author

If you revert some of your changes and push again to your branch, a new Travis build will eventually be triggered, and we can see the outcome then.

@KishkinJ10
Copy link

sir i have to rename this "transToNextStateOfBacktrack" back to "NextStateOfBacktrack" this or it will remain the same?

KishkinJ10 added a commit to KishkinJ10/modbat that referenced this issue Mar 31, 2021
KishkinJ10 added a commit to KishkinJ10/modbat that referenced this issue Mar 31, 2021
@cyrille-artho
Copy link
Owner Author

Please check the result of the build: https://travis-ci.com/github/cyrille-artho/modbat/builds/221803390
If the unit tests fail, there is a problem with the patch. You can run ./gradlew test on your local machine to see the results of the main unit tests (additional tests are currently run with bash bin/test.sh).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants