-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Microsoft Edge via Edge Diagnostics Adaptor #21
Comments
This sounds interesting! I'll play around with the adaptor as soon as I manage to get a Windows 10 box up and running. Anyway, if the adaptor behaves exactly as the original Remote Debugging Protocol this library should already work with it. The only difference would be the Also, related to #17, I was trying to add support for native ES6 promises to the current API; basically a promise is returned when the callback is omitted. I believe that maintaining both paradigms may be useful. This feature is mostly done, I'll merge it soon. |
Great! We also released https://github.com/microsoft/edge-diagnostics-launch, which is a node wrapper that fetches the adaptor binary and launches Edge with a given URL. That should make integration even easier. I'll give the feeding of the protocol.json a spin right away. |
Works perfectly. Here's a GIST that shows an example of chrome-remote-interface working with Edge. |
Hmm, I don't seem to be able to make it work, while the HTTP API works I cannot connect to the WebSocket. Here's what I tried:
I'm trying this in a (64 bit) VM. I get similar results with a 32 bit laptop, the difference is that here I don't get the |
@cyrus-and I opened an issue on the adapter, microsoft/edge-diagnostics-adapter#19 |
Edge already supports the remote debugging protocol (via Edge Diagnostics Adaptor). This commit allows to fetch the JSON protocol directly from Edge itself. Since it is not possible to do the same with Chrome, some changes were needed in order to provide a consistent API: * the protocol is fetched *remotely* by default (from the repository, for what concerns Chrome and from `/json/protocol`, for what concerns Edge); * the boolean returned by `Chrome.Protocol()` method is now named `fallback` instead of `fromChrome` (and the semantics changed accordingly). Related to #21 and closes #24.
[Cross posting from the Edge adapter issue 19] Hmmm. Honestly not sure what happened here. I believe that error code basically means it couldn't find the builtin name 'ALL APPLICATION PACKAGES' msdn. But that name should exsist on Win10 (and down to Windows 8). If you:
Fwiw and this is probably unrelated but the binaries should be somewhere local and not ran from a share. |
@auchenberg I finally managed (thanks to @andysterland) to fix this. After some very brief testing, the support for Edge seems to work properly. :) I'm going to bump a new release and push it on NPM. Let me know if you come across any issues. |
Yay 🎉 Big day! We'll let you know if issues arise. Thanks for the help! |
We at Microsoft has now made it possible to debug Microsoft Edge via Edge Diagnostics Adaptor over the Chrome Debugging Protocol.
It has a
protocol.json
file which could be fetched from the repo at https://github.com/Microsoft/edge-diagnostics-adaptor/blob/master/protocol.json, or we could add an HTTP endpoint to fetch it from something like/json/protocol
directly from the adaptor.We think it cold be exciting to have this library working with multiple browsers supporting the Chrome Debugging Protocol.
Are you interested in collaboration?
The text was updated successfully, but these errors were encountered: