Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index: track changes for modseq bump when setting seen on shared folders #4240

Merged
merged 4 commits into from Oct 10, 2022
Merged

index: track changes for modseq bump when setting seen on shared folders #4240

merged 4 commits into from Oct 10, 2022

Conversation

brong
Copy link
Member

@brong brong commented Sep 21, 2022

This fixes #3240 properly for new Cyrus

@brong brong requested a review from elliefm September 21, 2022 06:09
@brong brong added 3.6 affects 3.6 backport-to-3.6 for PRs that are to be backported to 3.6 labels Sep 21, 2022
elliefm
elliefm approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@elliefm elliefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really clean, nice.

I've run this through my updated tests from #3829 and it passes them. Do we want to add them to this PR? It's two commits that cherry pick easily enough.

@elliefm elliefm self-assigned this Sep 26, 2022
@elliefm elliefm added 3.4 affects 3.4 backport-to-3.4 for PRs that are to be backported to 3.4 labels Sep 26, 2022
@rjbs rjbs merged commit e5f7553 into master Oct 10, 2022
@elliefm elliefm removed the backport-to-3.6 for PRs that are to be backported to 3.6 label Oct 12, 2022
@elliefm elliefm removed 3.4 affects 3.4 3.6 affects 3.6 backport-to-3.4 for PRs that are to be backported to 3.4 labels Jan 13, 2023
@elliefm elliefm removed their assignment Jan 13, 2023
@elliefm elliefm mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliefm elliefm elliefm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seen/Unseen Flag not working correctly if sharedseen of a shared mailbox is not set to true
3 participants
@brong @elliefm @rjbs