-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MemoryPackUnion(ushort tag, Type type )] the "tag" parameter is kinda excessive, can it be removed or optional? #64
Comments
completely no, set explicitly. |
I don't care the sequence of the type registered, and the numebrs r not gonna be reused, why can't the generator just fill it automatically? |
If you have hundreds of them, you can just fill in the sequential numbers if they're auto-generated. If not, you can just fill them. |
ok, i got it, seems Version Toloerance also requires carefully handle of these numbers, in another word, the orders, right? is
equal to
? |
What do you do when you delete type. |
The order is not automatically random, u can INFER the order from the [MemoryPackUnion] declaration? What's the differences below?
|
or |
Suggest:
MemoryPackUnion(Type type, ushort? tag=null )]
if null, code generator assign the tag for each type accordingly.
I don't know why must serve this tag parameter to the the MemoryPackUnion attribute, it's boring to assign a sequence of unfriendly numbers which will not be used later to a pile of classes.
The text was updated successfully, but these errors were encountered: