Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add C++11 array #472

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jakirkham
Copy link
Contributor

@jakirkham jakirkham commented Dec 8, 2015

Adds the std::array interface. Requires C++11 to use. Not sure how this is handled currently.

EDIT: Currently blocked waiting for #426.

@molpopgen
Copy link
Contributor

While I'd love to see this work, I think there's a big problem. Currently(and AFAIK), Cython's compiler/code generator does not support non-type template parameters such as the size_t.

@jakirkham
Copy link
Contributor Author

I was also wondering about this issue of templates with non-type parameters. Oh well, I guess I can leave it here for someone to work on once that changes. Is there an issue already open for this enhancement?

@molpopgen
Copy link
Contributor

Yes, pull request #426, but it is failing tests right now.

@molpopgen
Copy link
Contributor

Also, your tests will fail as written, even if the type could compile. You need to provide the size_t for the calls to begin, end, etc,. too, as each different size_t would be a different std::array.

@jakirkham
Copy link
Contributor Author

You need to provide the size_t for the calls to begin, end, etc,. too, as each different size_t would be a different std::array.

By this, I am assuming you mean the type used to store these variables; not that the methods themselves needed to be templated in some fashion. This has been addressed.

Based on the discussion in the linked PR, it sounds like the manner in which templating of this nature may occur is still under active discussion. I'll revisit this once that gets settled and merged.

@molpopgen
Copy link
Contributor

That's right--the new tests have the correct syntax.

@jakirkham jakirkham mentioned this pull request Apr 4, 2017
3 tasks
@pums974
Copy link

pums974 commented Dec 14, 2020

Hi, Any progress here ?
I would love this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants