Update signature of make_unique #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tweak the selection for move-if-supported. This now lets the user enable it by a define even if the compiler support isn't detected. This is useful because the new signature for make_unique kind of relies on move-if-supported to work. Fixes cython#5560
scoder
reviewed
Jul 27, 2023
Cython/Utility/CppSupport.cpp
Outdated
Comment on lines
65
to
64
| // move should be defined for these versions of MSVC, but __cplusplus isn't set usefully | ||
| #if CYTHON_USE_CPP11_FEATURES |
There was a problem hiding this comment.
Seeing the comment, does _MSC_VER >= 1600 really imply the support for "C++11 features" in general, or just std::move? It seems that std::move is the only C++11 feature that we use internally, so why not call the feature flag CYTHON_USE_CPP_MOVE?
There was a problem hiding this comment.
Done that - c++11 support looks to be slowly implemented across multiple MSVC versions (of course this is probably true for every compiler...).
(I think we do use C++11 lambdas in one place, But we only do it if the user uses c++11 enums, so that doesn't really need a guard).
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tweak the selection for move-if-supported. This now lets the user enable it by a define even if the compiler support isn't detected. This is useful because the new signature for make_unique kind of relies on move-if-supported to work.
Fixes #5560