Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Stop working around Cython issues #14023

Closed
vyasr opened this issue Aug 31, 2023 · 2 comments
Closed

[FEA] Stop working around Cython issues #14023

vyasr opened this issue Aug 31, 2023 · 2 comments
Labels
0 - Backlog In queue waiting for assignment cuDF (Python) Affects Python cuDF API. feature request New feature or request

Comments

@vyasr
Copy link
Contributor

vyasr commented Aug 31, 2023

Is your feature request related to a problem? Please describe.
cudf Cython code currently contains various workarounds for Cython limitations. With the Cython 3 release, many of these limitations have been lifted. Cython development is quite active right now, and now that we have migrated to Cython 3 we can also track new minor/patch version updates easily if new issues are fixed. This is a tracking issue of the various workarounds in cudf that we should look into removing as they are resolved upstream.

Due to the ongoing pylibcudf effort, in general it will not make sense to fix these issues in legacy cudf Cython code. We should instead endeavor to fix these issues in new pylibcudf code that will replace legacy Cython over time.

Describe the solution you'd like

@vyasr vyasr added feature request New feature or request Needs Triage Need team to review and classify labels Aug 31, 2023
@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment cuDF (Python) Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Sep 27, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Nov 9, 2023

reference_wrapper, optional, and make_unique are handled in #14382

rapids-bot bot pushed a commit that referenced this issue Nov 10, 2023
All of these wrappers have now been upstreamed into Cython as of Cython 3.0.3.

Contributes to #14023

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Bradley Dice (https://github.com/bdice)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #14382
@vyasr
Copy link
Contributor Author

vyasr commented May 15, 2024

The outstanding work here is blocked on Cython improvements

I'll close for now since I don't see a timeline for any of this work. There are inline comments indicating that we're working around Cython limitations for those, so they're nice-to-have fixes if and when Cython updates accordingly.

@vyasr vyasr closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment cuDF (Python) Affects Python cuDF API. feature request New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants