LAMBJ-150 Invalid PhysicalResourceId Error (#480)

cythral · Feb 8, 2022 · 8199422 · 8199422
1 parent bab91ae
commit 8199422
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 3 deletions.
diff --git a/.github/releases/v0.9.2.md b/.github/releases/v0.9.2.md
@@ -0,0 +1,3 @@
+## Bug Fixes
+
+- Fixes an issue where custom resources would sometimes return an 'Invalid PhysicalResourceId' error.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -9,6 +9,9 @@
   "markdown.extension.toc.levels": "2..6",
   "editor.semanticHighlighting.enabled": true,
   "csharp.semanticHighlighting.enabled": true,
+  "files.exclude": {
+    "**/.nuget": true,
+  },
   "yaml.customTags": [
     "!And",
     "!And sequence",

diff --git a/src/CustomResource/CustomResourceRequest.cs b/src/CustomResource/CustomResourceRequest.cs
@@ -58,7 +58,7 @@ public class CustomResourceRequest
         /// for the requested custom resource.
         /// </summary>
         /// <value>The physical resource ID of the requested custom resource.</value>
-        public virtual string PhysicalResourceId { get; set; } = string.Empty;
+        public virtual string? PhysicalResourceId { get; set; }
 
         /// <summary>
         /// Gets or sets the extra properties that appear when deserializing a request to this type.

diff --git a/src/CustomResource/CustomResourceResponse.cs b/src/CustomResource/CustomResourceResponse.cs
@@ -20,7 +20,7 @@ public class CustomResourceResponse<TResourceOutputData>
         /// Gets or sets the physical resource ID of the requested custom resource.
         /// </summary>
         /// <value>The physical resource ID of the requested custom resource.</value>
-        public string PhysicalResourceId { get; set; } = string.Empty;
+        public string? PhysicalResourceId { get; set; }
 
         /// <summary>
         /// Gets or sets the ID of the CloudFormation stack the requested custom resource belongs to.

diff --git a/version.json b/version.json
@@ -1,6 +1,6 @@
 {
   "$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
-  "version": "0.9.1",
+  "version": "0.9.2",
   "publicReleaseRefSpec": [
     "^refs/tags/v\\d\\.\\d"
   ]