Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAMBJ-150 Invalid PhysicalResourceId Error #480

Merged
merged 2 commits into from
Feb 8, 2022
Merged

LAMBJ-150 Invalid PhysicalResourceId Error #480

merged 2 commits into from
Feb 8, 2022

Conversation

talenfisher
Copy link
Member

Fixes an issue where custom resources would sometimes return an invalid physical resource id error.

@talenfisher talenfisher added the bug Something isn't working label Feb 8, 2022
@talenfisher talenfisher self-assigned this Feb 8, 2022
@talenfisher talenfisher enabled auto-merge (squash) February 8, 2022 18:16
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #480 (8080a62) into master (bab91ae) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files          42       42           
  Lines         622      622           
=======================================
  Hits          580      580           
  Misses         42       42           
Impacted Files Coverage Δ
src/CustomResource/CustomResourceRequest.cs 100.00% <100.00%> (ø)
src/CustomResource/CustomResourceResponse.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab91ae...8080a62. Read the comment docs.

@talenfisher talenfisher merged commit 8199422 into master Feb 8, 2022
@talenfisher talenfisher deleted the LAMBJ-150 branch February 8, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant