Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout animation bug #47

Closed
ugurdogrusoz opened this issue Jul 9, 2017 · 3 comments
Closed

Layout animation bug #47

ugurdogrusoz opened this issue Jul 9, 2017 · 3 comments
Assignees
Labels

Comments

@ugurdogrusoz
Copy link
Contributor

This was discovered by @hasanbalci:
Open up daily Newt, set animation true (perform animation during layout), set incremental off (randomize: true) and perform layout on default graph. You'll see that at the very end of layout things get messed up (compounds placed in weird locations):
neuronal_muscle_signalling 7
This doesn't happen when animation if off (animation is set to 'end'). I don't know if this is somehow related to #45.
We suspect this was introduced after tiling was moved in l-level.

@metincansiper
Copy link
Contributor

@ugurdogrusoz I made the requested change for #45 and it did not solve this problem as I expected (Because that change is inside if(this.options.animate !== 'during'), but in this case animate option is 'during').

Then, in cose-bilkent go back to v1.6.7 where tiling is not moved to l-level yet. I see that this problem does not appear in v1.6.7. It appeared right after tiling is moved to l-level as you suspected.

metincansiper added a commit that referenced this issue Jul 10, 2017
@metincansiper
Copy link
Contributor

@ugurdogrusoz it seems to be fixed now.

@ugurdogrusoz
Copy link
Contributor Author

@hasanbalci can you verify and close the issue please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants