User thrashing of the compound dimensions cache during batching lower…

…s performance #1939
cytoscape · Aug 21, 2017 · 0f1761b · 0f1761b
1 parent 1c40b60
commit 0f1761b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/collection/dimensions/bounds.js b/src/collection/dimensions/bounds.js
@@ -48,6 +48,9 @@ elesfn.updateCompoundBounds = function(){
   // save cycles for non compound graphs or when style disabled
   if( !cy.styleEnabled() || !cy.hasCompoundNodes() ){ return this; }
 
+  // save cycles when batching -- but bounds will be stale (or not exist yet)
+  if( cy.batching() ){ return this; }
+
   let updated = [];
 
   function update( parent ){

diff --git a/src/core/notification.js b/src/core/notification.js
@@ -44,6 +44,10 @@ let corefn = ({
     this.notifications( true );
   },
 
+  batching: function(){
+    return this._private.batchCount > 0;
+  },
+
   startBatch: function(){
     let _p = this._private;