Renderer-calculated style values for an edge may not be fresh on call to getter #2608
Comments
maxkfranz
added a commit
that referenced
this issue
Jan 24, 2020
… to getter #2608 Rendered style is generally recalculated at the start of a frame rather than synchronously at the time of dirtying. This avoids redundant calculations. Further an edge is not explicitly dirtied when at least one of its connected nodes changes in dimensions (position, width, etc.). Instead, it is implicitly marked as dirty via the `cleanConnected` flag on the node. An immediate, synchronous recalculation of rendered style may happen for public functions that read rendered style, such as `edge.midpoint()`. For this case, `recalculateRenderedStyle()` must check whether an edge is implicitly dirty via `cleanConnected`.
maxkfranz
added a commit
that referenced
this issue
Jan 24, 2020
… to getter #2608 Rendered style is generally recalculated at the start of a frame rather than synchronously at the time of dirtying. This avoids redundant calculations. Further an edge is not explicitly dirtied when at least one of its connected nodes changes in dimensions (position, width, etc.). Instead, it is implicitly marked as dirty via the `cleanConnected` flag on the node. An immediate, synchronous recalculation of rendered style may happen for public functions that read rendered style, such as `edge.midpoint()`. For this case, `recalculateRenderedStyle()` must check whether an edge is implicitly dirty via `cleanConnected`.
maxkfranz
added a commit
that referenced
this issue
Jan 24, 2020
…t be fresh on call to getter #2608 #2609 Rendered style is generally recalculated at the start of a frame rather than synchronously at the time of dirtying. This avoids redundant calculations. Further an edge is not explicitly dirtied when at least one of its connected nodes changes in dimensions (position, width, etc.). Instead, it is implicitly marked as dirty via the `cleanConnected` flag on the node. An immediate, synchronous recalculation of rendered style may happen for public functions that read rendered style, such as `edge.midpoint()`. For this case, `recalculateRenderedStyle()` must check whether an edge is implicitly dirty via `cleanConnected`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue type
Bug report
Environment info
Current (buggy) behaviour
A call to a function like
edge.midpoint()may return a value that is not fresh w.r.t. recent bounds changes to the connected nodes.Desired behaviour
For an edge whose connected nodes have recently changed bounds (position, width, etc.), calls to functions like
edge.midpoint()should cause the renderer to recalculate the rendered style synchronously.Minimum steps to reproduce
See #2595
The text was updated successfully, but these errors were encountered: