Patch buildComponent in eles.htbc()
#2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For certain graph structures, it is possible for a single edge (or multiple, counting loops) to be omitted from a component during it's construction. This ensures that components are reconstructed in their entirety. - Add test case which fails without newest modification - Additional clean up - Rename `eles.hopcroftTarjan()` to `eles.htbc()` in documentation
maxkfranz
pushed a commit
that referenced
this pull request
Feb 7, 2020
- For certain graph structures, it is possible for a single edge (or multiple, counting loops) to be omitted from a component during it's construction. This ensures that components are reconstructed in their entirety. - Add test case which fails without newest modification - Additional clean up - Rename `eles.hopcroftTarjan()` to `eles.htbc()` in documentation Ref : #2622
|
Merged in for 3.13.1 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of the
buildComponentfunction withineles.htbc()there is a flaw such that, for certain graphs, a singular edge (or multiple, counting loops) will be omitted from acomponentscollection during it's respective construction. A minimal reproducible example of this behaviour can be seen here. The intent of this PR is to amend this issue.