Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chevron arrow to edge-arrows documentation #3149

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

MarkBoyes
Copy link
Contributor

@MarkBoyes MarkBoyes commented Aug 4, 2023

The chevron arrow was added to cytoscape.js in 2018 but has not been included in the online demo.

Associated issues: #3148

The PR adds the arrow: "none" seems like a special case, so I have left "none" at the end of the page and made chevron the penultimate example.

Checklist

Author:

  • The proper base branch has been selected. New features go on unstable. Bug-fix patches can go on either unstable or master.
  • Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix. Check this box if tests are not pragmatically possible (e.g. rendering features could include screenshots or videos instead of automated tests).
  • The associated GitHub issues are included (above).
  • Notes have been included (above).

Reviewers:

  • All automated checks are passing (green check next to latest commit).
  • At least one reviewer has signed off on the pull request.
  • For bug fixes: Just after this pull request is merged, it should be applied to both the master branch and the unstable branch. Normally, this just requires cherry-picking the corresponding merge commit from master to unstable -- or vice versa.

The chevron arrow was added to cytoscape.js in 2018 but has
not been included in the online demo. 

This was frustrating when this particular shape broke Firefox 115 and no pre-existing web page existed to include in the Firefox bug report!
@maxkfranz
Copy link
Member

This is a great catch, Mark.

It is important to have the 'none' example if the demo is to be exhaustive. Would you add the 'none' example back in?

@MarkBoyes
Copy link
Contributor Author

MarkBoyes commented Aug 5, 2023

Unless I fouled up the commit, the none case is still there as the new e11 joining n22 and n23

@maxkfranz
Copy link
Member

It looks like I misread the diff. My mistake.

I'll set aside some time in the next day or so to try out a build of the documentation and get this merged in.

Thanks for the PR.

@maxkfranz maxkfranz self-assigned this Aug 8, 2023
@maxkfranz maxkfranz merged commit df6882e into cytoscape:unstable Aug 14, 2023
1 check passed
maxkfranz added a commit that referenced this pull request Aug 14, 2023
Add chevron arrow to edge-arrows documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants