Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #75, #77: Add redundancy filter and evidence code filter #81

Merged
merged 2 commits into from Jul 13, 2022
Merged

Issue #75, #77: Add redundancy filter and evidence code filter #81

merged 2 commits into from Jul 13, 2022

Conversation

AkMo3
Copy link
Collaborator

@AkMo3 AkMo3 commented Jul 5, 2022

No description provided.

@AkMo3 AkMo3 requested a review from ighosh98 July 5, 2022 15:16
@AkMo3 AkMo3 mentioned this pull request Jul 7, 2022
Merged
@ighosh98
Copy link
Collaborator

ighosh98 commented Jul 8, 2022

Please try to minimize the number of commits in a PR. I don't think GitHub combines all the different commits into a single page. It makes tracking the changes made across commits to the same file harder.

@AkMo3
Copy link
Collaborator Author

AkMo3 commented Jul 8, 2022

Please try to minimize the number of commits in a PR. I don't think GitHub combines all the different commits into a single page. It makes tracking the changes made across commits to the same file harder.

Two different branches merged into one, hence a lot of commits. I will keep it in mind next time 👍

@AkMo3 AkMo3 marked this pull request as draft July 8, 2022 20:03
@ighosh98
Copy link
Collaborator

ighosh98 commented Jul 9, 2022

@AkMo3 please post when you are done making changes

@AkMo3
Copy link
Collaborator Author

AkMo3 commented Jul 9, 2022 •
edited

@ighosh98 @yihangx Can you both please check if you can filter results, save session, and reopen session again normally? In my Ubuntu system, the session file becomes so large sometimes that it is taking 10-15min to open it (reason I drafted this PR). In Windows it is working fine in my system. Use the latest JAR provided with this PR to run the checks. Thanks!

@AkMo3 AkMo3 marked this pull request as ready for review July 12, 2022 14:46
@AkMo3
Copy link
Collaborator Author

AkMo3 commented Jul 12, 2022

@ighosh98 Please have look.

@yihangx
Copy link
Member

yihangx commented Jul 13, 2022

@AkMo3 Reviewed. All behaviors are good.

@yihangx yihangx merged commit d2bc900 into main Jul 13, 2022
@AkMo3 AkMo3 deleted the REDUNDANT_TERMS branch July 14, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ighosh98 ighosh98 ighosh98 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AkMo3 @ighosh98 @yihangx