20230420 Maintenance #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives some slight tweaks to the project by updating the README for instructions to utilize a virtual environment, adding a requirements.txt file (which was not previously available), as well as creating the ability to utilize poetry (with an added poetry script specification). This does change `main.py` to `stixops.py`.
Fixes the poetry script definition for initializing the application. This changes the STIXOps.main to STIXOps.init_options for clarity. Additionally added the `if __name__ == "__main__"` item with a core main() function so that the script will run the same way if called by python alone, instead of by poetry.
signus
commented
Apr 20, 2023
| @@ -85,11 +85,11 @@ def writeSTIX(self, option): | |||
| name = str (input ("Enter malware name: ")) | |||
| family = str (input ("Does the malware have any relations [True/ False]? ")) | |||
| description = str (input ("Enter malware description: ")) | |||
| type = str (input ("Enter malware type: ")) | |||
There was a problem hiding this comment.
Also individually changed the type variables in the respective sections, as type is a protected keyword in Python. While this has not been observed to cause issues, it's best to change this.
When doing validations for indicator objects the STIX library warns that indicators SHOULD have both a name and a description. Added the ability to provide a description, even if blank. Can add some wrappers around this in later updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives some slight tweaks to the project by updating the README for instructions to utilize a virtual environment, adding a requirements.txt file (which was not previously available), as well as creating the ability to utilize poetry (with an added poetry script specification).
This does change
main.pytostixops.py.