Test and coverage tweaks

czim · May 27, 2017 · d2e3699 · d2e3699
1 parent c6ba0b8
commit d2e3699
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/src/Support/Resource/AbstractEloquentResource.php b/src/Support/Resource/AbstractEloquentResource.php
@@ -177,7 +177,7 @@ public function relationshipData($include)
     }
 
     /**
-     * Returns the JSON-API type for a given include
+     * Returns the JSON-API type for a given include.
      *
      * @param string $include
      * @return null|string
@@ -188,11 +188,9 @@ public function relationshipType($include)
         $relation = $this->includeRelation($include);
 
         if ($this->isVariableRelation($relation)) {
-
+            // @codeCoverageIgnoreStart
             if ( ! $this->isSingularRelation($relation)) {
-                // @codeCoverageIgnoreStart
                 return null;
-                // @codeCoverageIgnoreEnd
             }
 
             // Get the type for the actually related item
@@ -204,6 +202,7 @@ public function relationshipType($include)
             }
 
             return $this->getTypeMaker()->makeFor(new $modelClass);
+            // @codeCoverageIgnoreEnd
         }
 
         return $this->getTypeMaker()->makeFor(

diff --git a/tests/Support/Resource/EloquentResourceTest.php b/tests/Support/Resource/EloquentResourceTest.php
@@ -231,6 +231,18 @@ function it_returns_the_relation_method_instance_of_the_model_for_an_include_key
         static::assertInstanceOf(HasMany::class, $resource->includeRelation('comments'));
     }
 
+    /**
+     * @test
+     */
+    function it_returns_the_relationship_type_for_a_given_include()
+    {
+        $resource = new TestAbstractEloquentResource;
+
+        $resource->setModel(new TestPost);
+
+        static::assertEquals('test-comments', $resource->relationshipType('comments'));
+    }
+
     /**
      * @test
      */