Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme with wrapper examples #90

Merged
merged 1 commit into from
Oct 11, 2021
Merged

update readme with wrapper examples #90

merged 1 commit into from
Oct 11, 2021

Conversation

timnyborg
Copy link
Contributor

Explains securing the get_progress endpoint through wrappign and rerouting, wtih fbv and cbv examples

securing the get_progress endpoint
@czue
Copy link
Owner

czue commented Oct 11, 2021

Thank you for the contribution!

@czue czue merged commit cec18e4 into czue:master Oct 11, 2021
@czue
Copy link
Owner

czue commented Oct 11, 2021

One thought I only had after merging was that maybe this should state more explicitly that you also need to remove the celery progress urls from your root urlconf?

No pressure to submit another PR, but might be helpful. I'd still like to better support this out-of-the-box, but haven't found the time to work on this project lately...

@timnyborg
Copy link
Contributor Author

timnyborg commented Oct 11, 2021 via email

timnyborg added a commit to timnyborg/celery-progress that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants