-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TwitterAction #73
Conversation
Multiple fixes and few new features
FEATURE: Implement check for downloaded pastes
Pull Request Test Coverage Report for Build 86
💛 - Coveralls |
Thank you a lot for your contribution. Your work looks solid so far. Also lovely to create the PR to the dev branch so that I can test it thoroughly. I will try to set it up on friday and give feedback then. Big thanks for implementing the template feature as well. |
@@ -1,3 +1,4 @@ | |||
pymongo | |||
mysql-connector-python | |||
requests | |||
python-twitter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is not an issue I have been thinking several times about splitting the dependencies apart a bit (dependencies for pastepwn to function and dependencies for certain analyzers/actions to function) - see #38 for example. I am not a 100% sure on how to handle this, but this should be referenced, so that I think about it later.
Awesome. It works like a charm. Proof: https://twitter.com/pastepwn/status/1180535250792914946 Thank you once again @psidex :) |
Cool! Is it alright if I have a go at a couple of the other issues? |
Sure, take them as long as they are hot :) If you can think of anything useful, feel free to create new issues as well. |
My attempt at implementing the Twitter action (#71).
Unfortunately I can't test it as I don't have a Pastebin Pro account, and they currently aren't selling them, therefore I'm making this PR to the dev branch, so that it can be tested before definitely being added.
It uses the python-twitter package to deal with the Twitter API, and uses the same template system as the Telegram action.