Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TwitterAction #73

Merged
merged 4 commits into from
Oct 5, 2019
Merged

Implement TwitterAction #73

merged 4 commits into from
Oct 5, 2019

Conversation

psidex
Copy link
Contributor

@psidex psidex commented Sep 30, 2019

My attempt at implementing the Twitter action (#71).

Unfortunately I can't test it as I don't have a Pastebin Pro account, and they currently aren't selling them, therefore I'm making this PR to the dev branch, so that it can be tested before definitely being added.

It uses the python-twitter package to deal with the Twitter API, and uses the same template system as the Telegram action.

d-Rickyy-b and others added 4 commits September 4, 2019 16:44
@coveralls
Copy link

coveralls commented Sep 30, 2019

Pull Request Test Coverage Report for Build 86

  • 11 of 23 (47.83%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 56.68%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/actions/twitteraction.py 9 21 42.86%
Totals Coverage Status
Change from base Build 82: -0.2%
Covered Lines: 700
Relevant Lines: 1235

💛 - Coveralls

@d-Rickyy-b
Copy link
Owner

Thank you a lot for your contribution. Your work looks solid so far. Also lovely to create the PR to the dev branch so that I can test it thoroughly. I will try to set it up on friday and give feedback then. Big thanks for implementing the template feature as well.

@@ -1,3 +1,4 @@
pymongo
mysql-connector-python
requests
python-twitter
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is not an issue I have been thinking several times about splitting the dependencies apart a bit (dependencies for pastepwn to function and dependencies for certain analyzers/actions to function) - see #38 for example. I am not a 100% sure on how to handle this, but this should be referenced, so that I think about it later.

@psidex psidex changed the title Implement TwitterActtion Implement TwitterAction Oct 4, 2019
@d-Rickyy-b
Copy link
Owner

Awesome. It works like a charm. Proof: https://twitter.com/pastepwn/status/1180535250792914946

Thank you once again @psidex :)

@d-Rickyy-b d-Rickyy-b merged commit 17589af into d-Rickyy-b:dev Oct 5, 2019
@psidex
Copy link
Contributor Author

psidex commented Oct 5, 2019

Cool! Is it alright if I have a go at a couple of the other issues?

@d-Rickyy-b
Copy link
Owner

Sure, take them as long as they are hot :) If you can think of anything useful, feel free to create new issues as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants