Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds simple database dump analyzer. #75

Closed
wants to merge 1 commit into from
Closed

Adds simple database dump analyzer. #75

wants to merge 1 commit into from

Conversation

IpsumCapra
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Oct 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 88

  • 5 of 7 (71.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 56.967%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/analyzers/dbdumpanalyzer.py 4 6 66.67%
Totals Coverage Status
Change from base Build 84: 0.08%
Covered Lines: 2085
Relevant Lines: 3660
💛 - Coveralls

@d-Rickyy-b
Copy link
Owner

Hey there, thank you for your Pull Request.

Sadly the regex does not match the whole column names line, it does only match single words.
grafik

From my point of view it would be better to match the whole line. sedaboni implemented a full line match in #76.

@d-Rickyy-b d-Rickyy-b mentioned this pull request Oct 3, 2019
Closed
@d-Rickyy-b
Copy link
Owner

Implemented in #76

@d-Rickyy-b d-Rickyy-b closed this Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IpsumCapra @coveralls @d-Rickyy-b