Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database dump analyzer #76

Merged
merged 6 commits into from
Oct 5, 2019
Merged

Database dump analyzer #76

merged 6 commits into from
Oct 5, 2019

Conversation

sedaboni
Copy link

@sedaboni sedaboni commented Oct 1, 2019

I added a basic regex that match the columns

@coveralls
Copy link

coveralls commented Oct 1, 2019 •
edited

Pull Request Test Coverage Report for Build 119

  • 5 of 7 (71.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 60.331%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pastepwn/analyzers/databasedumpanalyzer.py 4 6 66.67%
Totals Coverage Status
Change from base Build 118: 0.06%
Covered Lines: 1606
Relevant Lines: 2662
💛 - Coveralls

@sedaboni sedaboni mentioned this pull request Oct 1, 2019
Closed
d-Rickyy-b
d-Rickyy-b requested changes Oct 3, 2019
View reviewed changes
Copy link
Owner

@d-Rickyy-b d-Rickyy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation in general. Two minor things to fix, then I'll merge them right away :)

Thank you for your work!

pastepwn/analyzers/databasedumpanalyzer.py Outdated Show resolved Hide resolved
pastepwn/analyzers/databasedumpanalyzer.py Outdated Show resolved Hide resolved
@d-Rickyy-b d-Rickyy-b mentioned this pull request Oct 3, 2019
Closed
d-Rickyy-b
d-Rickyy-b approved these changes Oct 5, 2019
View reviewed changes
Copy link
Owner

@d-Rickyy-b d-Rickyy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the changes.

@d-Rickyy-b d-Rickyy-b merged commit 0c87633 into d-Rickyy-b:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-Rickyy-b d-Rickyy-b d-Rickyy-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sedaboni @coveralls @d-Rickyy-b