Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD,MAINT: Fix C++14 builds #44

Merged
merged 12 commits into from
Aug 23, 2023
Merged

BLD,MAINT: Fix C++14 builds #44

merged 12 commits into from
Aug 23, 2023

Conversation

RuhiRG
Copy link
Member

@RuhiRG RuhiRG commented Aug 23, 2023

Closes #43.

HaoZeke
HaoZeke approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

.github/workflows/build_meson.yml Show resolved Hide resolved
amritagos
amritagos approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@amritagos amritagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RuhiRG .

@HaoZeke any way we could stop bundling sol like this? (perhaps for later)

@HaoZeke
Copy link
Member

HaoZeke commented Aug 23, 2023

@HaoZeke any way we could stop bundling sol like this? (perhaps for later)

Not without being even more tied to the build systems, this keeps things reasonably portable I guess... but would be nice.

@HaoZeke HaoZeke merged commit e42be0a into d-SEAMS:main Aug 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoZeke HaoZeke HaoZeke approved these changes

@amritagos amritagos amritagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAINT: Unify packages for C++14
3 participants
@RuhiRG @HaoZeke @amritagos