-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BrainFPV (+history -branding) #36
Conversation
4546a04
to
848219a
Compare
@@ -1,4 +1,17 @@ | |||
# Tau Labs | |||
# Tau Labs - Brain FPV Flight Controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope :-P
Also, I don't know if we should really keep all the brain stuff below since we don't detail other targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to merge this if we've got a new readme.md from #4 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will drop this out. Just an artefact of the rebase.
There are a few indentation issues, and unrelated things that seem to have slipped in but on the whole this looks good once those are addressed. I haven't reviewed any of the brain specific code in detail since it isn't new code and has prior test. |
It's a pain that Github won't show all the diff so you have to drill through individual commits to add comments. :-( |
I'm generally dissatisfied with github's code review. It's slightly better than it used to be, but I use good stuff every day. :/ |
jenkins, test this please |
3311852
to
64b92bf
Compare
needs eventdispatcher.c removed from Makefile |
@mlyle got it thx, looking |
64b92bf
to
6637c41
Compare
Was conflict from another PR since, so, not even your fault :) |
* This commit re-adds a few missing files that were automatically resolved toward the upstream side in the rebase. * Add missing taskinfo fields (onscreendisplay) * Tabify taskinfo.xml * Enable BrainFPV modules * Add OSD board capabilities to other targets.Only the BrainFPV supports OSD, so these are all false.
6637c41
to
38fa18f
Compare
fixed the sparkybgc conflict.. (38fa18f) |
@@ -0,0 +1,633 @@ | |||
/******************************************************************************* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently used by the OSD. Compared to the other printf in, it has floating point support. However, there are some weird bugs that can lead to a crash, so we should find a better solution at some point. c.f.
This looks good to me. Thanks for the hard work @fujin. Does this mean d-ronin is open to have closed hw boards in-tree? Having in-tree support for Brain (and future boards) would definitely be a good reason for BrainFPV to adopt d-ronin as official firmware. |
:) Yes we want to merge brain as soon as you give the OK. It would be really nice if you could give us some kind of cut-down schematic --- just what you're comfortable with --- to make it easier to maintain. I know it's not essential but some people (me) have an easier time keeping track of I/O's/assignments when looking at a picture. |
@mlyle yes, I'm fine with merging. I will click the button then :). I can add the schematic that shows everything except the OSD part, it will make it easier to develop for the board. |
Add BrainFPV (+history -branding)
Brain not built as part of make package, at least for Windows build environment. |
@jihlein thanks for the report. package and branding is going to pretty much completely change in the next few days so it may not be worth any effort. |
I have extracted the entire Brain history, minus any branding-specific changes, during the time that Brain was maintained out of tree and TauLabs was operational (up to the fork point, next.. some time, along Endo.)
Any branding changes can be re-made (I have them on another branch) by BrainFPV LLC for branding-specific/marketing release, would be my thought. I'm certainly happy to help.
TODO