Indent NANDManager #365
Merged
Indent NANDManager #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's not how I'd have indented it. The stuff below the labels is not a function, not even a pseudo function. It's goto-spaghetti-code - I think that should not be indented. Otherwise, it's fine. |
windows-server-2003
force-pushed
the
indent
branch
from
100b532
to
2f7fbd7
Compare
|
I think it's a pseudo function. |
windows-server-2003
force-pushed
the
indent
branch
from
2f7fbd7
to
20fcbc3
Compare
|
Yeah, this is exactly what I’d have done. I offered to indent his scripts for him, but he didn’t want to. Well, still not as crazy as my friend who wrote his whole website in one LONG line of HTML. |
|
I said I didn't have time to do it. If you do, more power to you. I still don't even have a proper splash image for my AIO, never mind preview screens. |
|
Alright, merged - thanks everyone! |
d0k3
pushed a commit
that referenced
this pull request
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.